Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update simulationData after re-simulation #985

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

chadoh
Copy link
Contributor

@chadoh chadoh commented Jun 7, 2024

The new test added here shows that you can edit a transaction with tx.raw = cloneFrom(tx.build) and that the tx.simulationData will be updated correctly.

simulationData is effectively a cache, and we need to make sure we clear it when you re-simulate.

Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you outline the bug/cause/fix from your PR description into the changelog?

The new test added here shows that you can edit a transaction with
`tx.raw = cloneFrom(tx.build)` and that the `tx.simulationData` will be
updated correctly.
@chadoh
Copy link
Contributor Author

chadoh commented Jun 13, 2024

Added the changelog entry. One of these days I'll start remembering without being asked! 😅

@Shaptic Shaptic merged commit 7dc0a8c into stellar:master Jun 13, 2024
10 checks passed
@chadoh chadoh deleted the fix/sim-data-cache branch June 13, 2024 18:55
@Shaptic Shaptic mentioned this pull request Jun 14, 2024
BlaineHeffron pushed a commit to AhaLabs/js-stellar-sdk that referenced this pull request Jun 20, 2024
The new test added here shows that you can edit a transaction with
`tx.raw = cloneFrom(tx.build)` and that the `tx.simulationData` will be
updated correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants