Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add auto restore functionality for contract client #991

Merged
merged 21 commits into from
Jun 14, 2024

Conversation

chadoh
Copy link
Contributor

@chadoh chadoh commented Jun 13, 2024

Port of #974, because Blaine is out and I don't have permission to push to his fork. This just resolves the conflicts with master.

Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coupla big questions but otherwise just being pedantic! Almost LGTM 👏

src/contract/assembled_transaction.ts Outdated Show resolved Hide resolved
src/contract/assembled_transaction.ts Outdated Show resolved Hide resolved
src/contract/assembled_transaction.ts Outdated Show resolved Hide resolved
src/contract/assembled_transaction.ts Outdated Show resolved Hide resolved
src/contract/assembled_transaction.ts Outdated Show resolved Hide resolved
src/contract/assembled_transaction.ts Outdated Show resolved Hide resolved
src/contract/assembled_transaction.ts Outdated Show resolved Hide resolved
src/contract/utils.ts Show resolved Hide resolved
chadoh and others added 2 commits June 13, 2024 16:45
Co-authored-by: George <Shaptic@users.noreply.github.com>
Co-authored-by: George <Shaptic@users.noreply.github.com>
@Shaptic
Copy link
Contributor

Shaptic commented Jun 14, 2024

@BlaineHeffron I can merge these as soon as e2e tests pass 👍

@BlaineHeffron
Copy link
Contributor

There was a missing check that didnt get caught in the merge from the toXDR / fromXDR PR. Should be good now!

@BlaineHeffron
Copy link
Contributor

Actually looks like the unit test I had written for this PR is failing, let me look into that.

@BlaineHeffron
Copy link
Contributor

Good to go now

@Shaptic Shaptic merged commit 556ffe8 into stellar:master Jun 14, 2024
10 checks passed
@Shaptic Shaptic mentioned this pull request Jun 14, 2024
BlaineHeffron added a commit to AhaLabs/js-stellar-sdk that referenced this pull request Jun 20, 2024
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Co-authored-by: blaineheffron <baheffron@gmail.com>
Co-authored-by: George <Shaptic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants