-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add auto restore functionality for contract client #991
Conversation
fix name Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
better description Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Better auto restore failure message. Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coupla big questions but otherwise just being pedantic! Almost LGTM 👏
Co-authored-by: George <Shaptic@users.noreply.github.com>
Co-authored-by: George <Shaptic@users.noreply.github.com>
Co-authored-by: George <Shaptic@users.noreply.github.com>
@BlaineHeffron I can merge these as soon as e2e tests pass 👍 |
There was a missing check that didnt get caught in the merge from the toXDR / fromXDR PR. Should be good now! |
Actually looks like the unit test I had written for this PR is failing, let me look into that. |
Good to go now |
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com> Co-authored-by: blaineheffron <baheffron@gmail.com> Co-authored-by: George <Shaptic@users.noreply.github.com>
Port of #974, because Blaine is out and I don't have permission to push to his fork. This just resolves the conflicts with
master
.