Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure float is turned off #563

Closed
graydon opened this issue Nov 4, 2022 · 3 comments
Closed

ensure float is turned off #563

graydon opened this issue Nov 4, 2022 · 3 comments
Assignees
@graydon @jayz22
Labels
bug Something isn't working

Comments

@graydon
Copy link
Contributor

graydon commented Nov 4, 2022

It looks like we might not be properly disabling floating point ops:

stellar/rs-soroban-sdk#753

We need to make sure they're really turned off.
@graydon graydon added the bug Something isn't working label Nov 4, 2022
@graydon graydon self-assigned this Nov 4, 2022
@jayz22 jayz22 self-assigned this Dec 14, 2022
@jayz22
Copy link
Contributor

jayz22 commented Dec 14, 2022

I can take a look at this issue.

@graydon
Copy link
Contributor Author

graydon commented Apr 25, 2023

Depends on upgrading wasmi, which depends on hooking up to wasmi's new metering system.

@jayz22
Copy link
Contributor

jayz22 commented Jun 5, 2023

Resolved in #815

@jayz22 jayz22 closed this as completed Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graydon graydon

@jayz22 jayz22

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graydon @jayz22