Switch to wasmi native fuel metering #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests passing against my wasmi branch. |
Add wasmi memory fuel metering; all tests pass
graydon
requested changes
Jun 2, 2023
There was a problem hiding this comment.
Fairly good progress! A bit of refactoring in VM would be nice, and removal of asserts, but I think it's going in the right direction.
The division-losing-fuel problem is the bit that kinda seems bad to me. I'm not sure it's bad, but it seems like it might be. Perhaps we can discuss tomorrow?
graydon
requested changes
Jun 2, 2023
There was a problem hiding this comment.
Fairly good progress! A bit of refactoring in VM would be nice, and removal of asserts, but I think it's going in the right direction.
The division-losing-fuel problem is the bit that kinda seems bad to me. I'm not sure it's bad, but it seems like it might be. Perhaps we can discuss tomorrow?
dmkozh
reviewed
Jun 2, 2023
jayz22
changed the title
This was referenced Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Pinned to my local wasmi branch: https://github.com/jayz22/wasmi/tree/soroban-fuel-metering
This PR adapts to wasmi upstream changes between v0.16 and v0.30. In particular the fuel metering features (resolves #683).
Changes include:
wasmi::core::FromValueno longer exist), added a new traitWasmiMarshal.invoke_functionon the VMdispatchWhy
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
We did not successfully get rid of the fork because of Wasmi does not have:
Fuel, andFuelCostsResourceLimiterwhich will allow host limiting and charging the maximum amount of memory upfront. We will switch to it when the feature is ready (AddResourceLimitertowasmi::Storewasmi-labs/wasmi#728).Still need to recalibrate the fuel costs.