-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ResourceLimiter
to wasmi::Store
#728
Comments
@Robbepop do you have any rough estimation on the timeline? I'm definitely very interested in this feature and would be willing to help if needed. |
Sorry for my late response! At the moment I am working on #729 which takes a big chunk of my time. I thought that this issue might be a perfect candidate for external contributions since it should be a rather local change. If it is extremely pressing we can probably work something out together. Shouldn't be a big task from what I see so far. |
@Robbepop ok if you're comfortable having us implement this, we're happy to direct our efforts to it. It looks like it ought to be relatively straightforward. |
@graydon Yes I am very comfortable with this being contributed externally. From the top of my head this should be fairly straight forward to implement. The worst thing that could happen is that we have to figure out performance issues reported by the CI since edit: I updated this issue's TODO list to properly reflect the required work items. The |
As requested in this comment some
wasmi
users could profit from having access to a Wasmtime styleResourceLimiter
API.Since
wasmi
tries to mirror the Wasmtime API we should and could mirror this API from Wasmtime as well. I think it would be a nice addition, however, special care has to be taken that translation and execution performance do not regress.TODOs
ResourceLimiter
trait inwasmi
.Store::limiter
API.StoreLimits
type implementingStoreLimiter
trait as convenience for users.StoreLimitsBuilder
type as convenience for constructingStoreLimits
.wasmi
performance too much.wasmi
performance significantly.Note: Wasmtime's
epoch_interruption
is not needed sincewasmi
does not (yet) supportasync
execution.The text was updated successfully, but these errors were encountered: