Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Err reform #940

Merged
merged 1 commit into from
May 19, 2023
Merged

Err reform #940

merged 1 commit into from
May 19, 2023

Conversation

graydon
Copy link
Contributor

@graydon graydon commented May 14, 2023

This is the companion PR to stellar/rs-soroban-env#806 (and stellar/rs-stellar-xdr#258 and stellar/stellar-xdr#92) overhauling error codes and renaming Status to Error.

@graydon graydon force-pushed the err-reform branch 5 times, most recently from a242aa3 to f1e963a Compare May 19, 2023 02:41
@graydon graydon marked this pull request as ready for review May 19, 2023 02:41
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Few questions inline.

soroban-sdk/src/logging.rs Show resolved Hide resolved
soroban-sdk/src/address.rs Show resolved Hide resolved
tests/logging/src/lib.rs Show resolved Hide resolved
@graydon graydon merged commit 710cd19 into main May 19, 2023
@graydon graydon deleted the err-reform branch May 19, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants