This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
keytree: new package for key derivation scheme with Ristretto and Merlin #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tessr
reviewed
Feb 21, 2019
tessr
reviewed
Feb 21, 2019
| ```rust | ||
| struct Xprv { | ||
| scalar: Scalar, | ||
| dk: [u8; 32] |
There was a problem hiding this comment.
Wait, what does the notation on this line mean?
There was a problem hiding this comment.
i lazily used Rust syntax for fixed-length arrays: [T; N]: N items of type T. u8 is 8-bit unsigned integer aka "byte".
There was a problem hiding this comment.
[T] is a type for "slice" that's of a dynamically known size, while [T;N] is an "array" of statically-known size.
There was a problem hiding this comment.
Oh, nice, thanks. I just got to the arrays section of this ole Rust book
keytree/keytree.md
Outdated
|
|
||
| ### Generate key | ||
|
|
||
| 1. Take RNG |
There was a problem hiding this comment.
Random number generator. Yeah, that was a quick draft. Will expand.
vickiniu
reviewed
Feb 22, 2019
oleganza
commented
Feb 22, 2019
oleganza
force-pushed
the
oleg/keytree
branch
2 times, most recently
from
c4ee05e to
9952c82
Compare
vickiniu
reviewed
Feb 22, 2019
Co-Authored-By: oleganza <oleganza@gmail.com>
Co-Authored-By: oleganza <oleganza@gmail.com>
Co-Authored-By: oleganza <oleganza@gmail.com>
Co-Authored-By: oleganza <oleganza@gmail.com>
oleganza
force-pushed
the
oleg/keytree
branch
from
9a4f317 to
b5fe704
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a draft of a spec. It's a good new-to-Rust issue to implement (in a separate PR).