Adds stellar-wallet-kit and refactors to use it #18
Conversation
|
Preview is available here: |
|
Nice - thanks for doing this. I think we can live with those blocking issues in exchange for getting more robust wallet support. It's a slightly worse UX but is still functional in that the wallet will notify the user of a network mismatch. Also, the lack of futurenet support in other wallets is a bummer, but we'll be going to Testnet pretty soon, so I think it's okay if the experience doesn't work on some wallets for the time being |
|
I think one side effect of this change would be that we now need the user to provide or select the network. For right now, we can assume Futurenet but will soon need to support Testnet also. It was nice to be able to implicitly support whatever network the user is on by getting it from Freighter but seems like no other wallets have apis for that. |
aristidesstaffieri
changed the title
|
Preview is available here: |
aristidesstaffieri
force-pushed
the
spike/stellar-wallet-kit
branch
from
42593b3 to
0fc4c7a
Compare
aristidesstaffieri
changed the title
|
Preview is available here: |
| @@ -14,6 +14,7 @@ module.exports = { | |||
| }, | |||
| ], | |||
| rules: { | |||
| "react-hooks/exhaustive-deps": "error", | |||
There was a problem hiding this comment.
Look like we need to update @stellar/eslint-config to be able to print the react hooks suggestions. Added this in the meantime.
|
Preview is available here: |
| @@ -73,7 +73,7 @@ | |||
| "eslint-plugin-jsx-a11y": "6.x", | |||
| "eslint-plugin-prefer-arrow": "^1.2.3", | |||
| "eslint-plugin-react": "^7.14.3", | |||
| "eslint-plugin-react-hooks": "2.x", | |||
| "eslint-plugin-react-hooks": "^5.0.0-canary-d1c8cdae3-20230619", | |||
There was a problem hiding this comment.
|
Something went wrong with PR preview build please check |
aristidesstaffieri
force-pushed
the
spike/stellar-wallet-kit
branch
from
a82ef49 to
5a07bc9
Compare
|
Preview is available here: |
This adds stellar-wallets-kit and refactors connecting/signing in order to use it.
This accomplishes support for more wallets and ecosystem integration into our examples.
Changes -
Uses stellar-wallets-kit to add support for x-bull and albedo.
Refactors to use SWK connections.
UX Changes -
Adds back the network selector since we can no longer detect network details, only allows Futurenet right now.