Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description of nomination leader election algorithm #990

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

bboston7
Copy link
Contributor

Part of stellar/stellar-core#4387

This change adds a section to the admin guide explaining the impact of validator quality levels on SCP nomination leader election.

@stellar-jenkins
Copy link

@nano-o
Copy link
Contributor

nano-o commented Sep 18, 2024

Are we leaving out "CRITICAL" on purpose? I opened an issue about it yesterday for another part of the docs: #985

@briwylde08
Copy link
Contributor

Couple editorial nits but will defer to @marta-lokhova for content correctness and approval 🙏

@stellar-jenkins
Copy link

@marta-lokhova
Copy link
Contributor

Thanks for documenting leader election! I have a similar question to @nano-o's - do we want to mention CRITICAL quality as well?

@bboston7
Copy link
Contributor Author

The problem is that there's no mention of CRITICAL anywhere else in the docs, so I think it would be wrong/confusing to mention it only in the nomination leader election section. We could add a description of CRITICAL to the admin docs, but I'm not sure whether CRITICAL was intentionally left out of the docs, which is what I think @nano-o's question is getting at.

@bboston7
Copy link
Contributor Author

bboston7 commented Oct 1, 2024

After some discussion with @marta-lokhova we decided to add a generic, level-agnostic description of the algorithm, as well as an example using HIGH, MEDIUM, and LOW quality validators. I'll make that change and ping @marta-lokhova when it's ready.

Part of stellar/stellar-core#4387

This change adds a section to the admin guide explaining the impact of
validator quality levels on SCP nomination leader election.
@bboston7
Copy link
Contributor Author

we decided to add a generic, level-agnostic description of the algorithm, as well as an example using HIGH, MEDIUM, and LOW quality validators.

I just pushed up a change that accomplishes this, and rebased on main. @marta-lokhova, this is ready for another round of review when you have a moment!

@stellar-jenkins
Copy link

@marta-lokhova marta-lokhova merged commit 76d30f8 into stellar:main Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants