Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: simplify the generated XDR code. #198

Merged
merged 2 commits into from
May 29, 2024

Conversation

overcat
Copy link
Contributor

@overcat overcat commented May 29, 2024

  • Move toXdrByteArray and toXdrBase64 into the interface as default methods.
  • Remove the static encode method.
  • No longer import all constants.

lightsail-network/java-stellar-sdk#597

@overcat
Copy link
Contributor Author

overcat commented May 29, 2024

Hi @tamirms, would you mind reviewing this PR? It further simplifies the generated Java code.

@tamirms
Copy link
Contributor

tamirms commented May 29, 2024

@overcat would you like me to merge the PR?

@overcat
Copy link
Contributor Author

overcat commented May 29, 2024

@overcat would you like me to merge the PR?

Yes, please merge it.

@tamirms tamirms merged commit bdf833d into stellar:master May 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants