-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken line break output when running via docker compose v2.2.x #160
Conversation
I'm not sure this fix would be compatible with Windows in an environment like Powershell. I've tested this out locally and the fix is introducing issues: |
Do not apply on Windows, do not apply when not running `docker compose` commands.
I've pushed a fix to try and apply the fix more selectively. |
Thanks, I just assumed everyone was using WSL2 these days. Do note that the bug itself is only when running Your screenshots are just the docker compose output. I pulled down your changes and the bug is once again there: slic dc exec slic "ls -al" |
@lucatume pushed 3e216d0...c75a0e2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again and it's all working correctly now.
Since upgrading to the new
docker compose
binary (running v2.2.2 on my system), line break outputs have been broken whendocker compose exec
is run. GitHub Issue, work aroundBefore this bugfix:
After this bugfix:
I tested it as well with
docker-compose
, which is running v2.17.2 on my system and this didn't change the output either way, so it seems backwards compatible.I also tested running with
docker compose exec -T
but that didn't make a difference either way, with or without the trailing' </dev/null'
.