Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version from docker compose yaml files #177

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

defunctl
Copy link
Contributor

@defunctl defunctl commented Apr 4, 2024

Using the latest docker compose v2 (and since v2.25), it shows warnings like:

[debug] Executing command: XDH=host.docker.internal docker compose -f "/home/xxxx/projects/slic/slic-stack.yml" ps --services --filter "status=running"

WARN[0000] /home/xxxx/projects/slic/slic-stack.yml: `version` is obsolete 

This removes the version from those files and removes the warning for me.

More info:

@defunctl defunctl added this to the 1.5.2 milestone Apr 4, 2024
@defunctl defunctl requested a review from lucatume April 4, 2024 19:17
@defunctl defunctl self-assigned this Apr 4, 2024
@lucatume lucatume changed the base branch from main to 1.5.2 April 5, 2024 09:17
@lucatume
Copy link
Contributor

lucatume commented Apr 5, 2024

I've tested the change on my older docker compose install, pre v2.25 and it works correctly.

As noted in the Docker issue linked, the version entry has been just informative, and not authoritative, for some time now.

@lucatume lucatume merged commit b2fe49f into 1.5.2 Apr 5, 2024
@defunctl defunctl deleted the chore/docker-compose-v2-version-obsolete branch April 5, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants