support lists of resources in rules #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhitchon
reviewed
Jul 14, 2018
linter/resource_linter.go
Outdated
| assertion.Debugf("using the rule - list of resources") | ||
| filteredResources = assertion.FilterResourcesByTypes(resources, rule.Resources, rule.Category) | ||
| } | ||
| for _, resource := range filteredResources { |
There was a problem hiding this comment.
I would recommend extracting these lines into a new filter function in assertion/util.go. Maybe call it FilterResourcesForRule? Pass the list of Resource objects and the entire Rule object. That would keep this loop code more concise, and groups all the filtering logic together in the same package. What do you think?
There was a problem hiding this comment.
I agree, this is a cleaner way of doing things.
rmorris1218
commented
Jul 15, 2018
linter/resource_linter.go
Outdated
| assertion.Debugf("using the rule - list of resources") | ||
| filteredResources = assertion.FilterResourcesByTypes(resources, rule.Resources, rule.Category) | ||
| } | ||
| for _, resource := range filteredResources { |
There was a problem hiding this comment.
I agree, this is a cleaner way of doing things.
kmonihen
pushed a commit
that referenced
this pull request
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2