Dynamic member lookup #246
Merged
+52
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a really useful addition to stencil (that I'm currently using) that really ought to be merged in. Very handy. |
|
Presuming this 4 year old PR isn't going to get merged? |
djbe
force-pushed
the
dynamic-member-lookup
branch
from
5819c29
to
f72f1b9
Compare
|
Hey 👋 I'm Eve, the friendly bot watching over Stencil 🤖 Thanks a lot for your contribution! Seems like everything is in order 👍 You did a good job here! 🤝 Generated by 🚫 Danger |
djbe
force-pushed
the
dynamic-member-lookup
branch
2 times, most recently
from
5ffefb5
to
9d55144
Compare
djbe
force-pushed
the
dynamic-member-lookup
branch
from
9d55144
to
099b841
Compare
djbe
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to
@dynamicMemberLookupin Swift. Would be ideal if there was a way to check if the type supports this in runtime but it's not possible, so had to introduce a custom protocol for that.Alternatively, we could have a protocol
StencilContextConvertiblethat will require to expose dictionary to be used in template context, but that will require to add all properties in such dictionary, even those accessible through reflection, instead of only those which are not accessible this way.Unfortunately, this does not work out of the box (by just adding
DynamicMemberLookupconformance) with@dynamicMemberLookupunless type defines subscript withAny?return type.Resolves #219