Trim whitespace #287
Merged
Trim whitespace #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
ilyapuchka
approved these changes
Dec 7, 2019
There was a problem hiding this comment.
This is amazing to see finally moving forward. I didn't go deep into implementation as I trust by this time it should be correct enough and tests look fine as well, only have few minor suggestions.
But we also need to update docs at least before this is released.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hey 👋 I'm Eve, the friendly bot watching over Stencil 🤖 Thanks a lot for your contribution! Seems like everything is in order 👍 You did a good job here! 🤝 Generated by 🚫 Danger |
|
I've rebased the changes on top of the (currently still open) drop swift4 PR, TODO:
|
djbe
force-pushed
the
trim_whitespace
branch
3 times, most recently
from
7933fab
to
07d9fb1
Compare
djbe
approved these changes
Jul 28, 2022
Closed
|
Thank you @djbe for getting this across the line! Awesome work here in the repo in the last couple of days 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the work that @bejar37 started in #92 and builds upon it.
In addition to the Jinja2 trimming symbols, this adds a
trimBehavior: TrimBehaviouronEnvironment. This defaults to.nonebut can be customized. It also comes with a built in.smartcase that removes whitespace before a block, and whitespace and a single newline after a block.