-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TCP connection away from Mac Network lib over to swift-nio enabling #5
Merged
stensoosaar
merged 8 commits into
stensoosaar:main
from
TradeWithIt:feat/move-connection-to-nio
Apr 25, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8e3ec99
add git ignore
shial4 89fc142
update dependencies
shial4 16a5abf
Use swift-nio for TCP connection
shial4 2a02280
Merge branch 'main' into feat/move-connection-to-nio
shial4 56fd9af
update package
shial4 85735fd
handle connection
shial4 3c9b99d
fix frame misalignment
shial4 28723ec
Fix connection sequence
shial4 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,8 +24,6 @@ | |
// | ||
|
||
import Foundation | ||
import Network | ||
|
||
|
||
extension IBClient: IBConnectionDelegate { | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
// | ||
// IBConnection.swift | ||
// IBKit | ||
// | ||
// Permission is hereby granted, free of charge, to any person obtaining a copy | ||
// of this software and associated documentation files (the "Software"), to deal | ||
// in the Software without restriction, including without limitation the rights | ||
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
// copies of the Software, and to permit persons to whom the Software is | ||
// furnished to do so, subject to the following conditions: | ||
// | ||
// The above copyright notice and this permission notice shall be included in all | ||
// copies or substantial portions of the Software. | ||
// | ||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
// SOFTWARE. | ||
// | ||
|
||
import NIOCore | ||
|
||
class IBClientFrameDecoder: ByteToMessageDecoder & NIOSingleStepByteToMessageDecoder { | ||
typealias InboundIn = ByteBuffer | ||
typealias InboundOut = ByteBuffer | ||
|
||
func decode(context: ChannelHandlerContext, buffer: inout ByteBuffer) throws -> DecodingState { | ||
if let frame = try self.readFrame(buffer: &buffer) { | ||
context.fireChannelRead(wrapInboundOut(frame)) | ||
return .continue | ||
} else { | ||
return .needMoreData | ||
} | ||
} | ||
|
||
func decode(buffer: inout NIOCore.ByteBuffer) throws -> NIOCore.ByteBuffer? { | ||
return try self.readFrame(buffer: &buffer) | ||
} | ||
|
||
func decodeLast(context: ChannelHandlerContext, buffer: inout ByteBuffer, seenEOF: Bool) throws -> DecodingState { | ||
while try self.decode(context: context, buffer: &buffer) == .continue {} | ||
if buffer.readableBytes > 0 { | ||
context.fireErrorCaught(IBError.failedToRead("leftover bytes")) | ||
} | ||
return .needMoreData | ||
} | ||
|
||
func decodeLast(buffer: inout ByteBuffer, seenEOF: Bool) throws -> InboundOut? { | ||
let decoded = try self.decode(buffer: &buffer) | ||
if buffer.readableBytes > 0 { | ||
throw IBError.failedToRead("leftover bytes") | ||
} | ||
return decoded | ||
} | ||
|
||
private func readFrame(buffer: inout ByteBuffer) throws -> ByteBuffer? { | ||
guard buffer.readableBytes >= 4 else { | ||
return nil | ||
} | ||
|
||
let lengthPrefix = buffer.getInteger(at: buffer.readerIndex, as: Int32.self)! | ||
let frameLength = Int(lengthPrefix.littleEndian) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI: |
||
|
||
guard buffer.readableBytes >= 4 + frameLength else { | ||
return nil | ||
} | ||
|
||
buffer.moveReaderIndex(forwardBy: 4) | ||
let frame = buffer.readSlice(length: frameLength) | ||
return frame | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I did implemented correctly frames decoding, but I left some comments here. Let me know how does it look.
This handler is mostly responsible for reading data and packaging them up into frames.