Fix sentence and remove existing action comments #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjundashrath
changed the title
| @@ -76,6 +76,13 @@ func PinAction(action, inputYaml string) (string, bool) { | |||
| pinnedAction := fmt.Sprintf("%s@%s # %s", leftOfAt[0], commitSHA, tagOrBranch) | |||
| updated = !strings.EqualFold(action, pinnedAction) | |||
| inputYaml = strings.ReplaceAll(inputYaml, action, pinnedAction) | |||
| stringParts := strings.SplitN(inputYaml, pinnedAction, 2) | |||
There was a problem hiding this comment.
@Devils-Knight can you please review this code? I think you had worked on this code recently, so just review this logic once. Also confirm if this change is on the latest from main.
|
@varunsh-coder the above logic looks fine to me and also the changes are on latest with reference to main. |
|
|
||
| steps: | ||
| - name: Close Issue | ||
| uses: peter-evans/close-issue@v1 #Mock comment to remove |
There was a problem hiding this comment.
@arjundashrath can you please update this test workflow to have two jobs and use the same Action with comment in both jobs? Also, have another Action in one of the jobs with a comment. I want to check if it will fix this for multiple instances and more complex workflows.
|
@varunsh-coder added a more complex test case |
varunsh-coder
added a commit
that referenced
this pull request
Apr 13, 2023
This reverts commit 830739d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2056
closes #2064
@varunsh-coder I rebased it. This PR has both the bug fixes