Connection::run(query: Insert) failed to unwrap lastInsertRowid with OnConflict.Ignore

[asfdfdfd]

branch: swift-2
commit: 8bd27bc

Model

class News {

    let id: Int
    let header: String

    init(row: Row) {
        id = row[NewsColumn.Id]
        header = row[NewsColumn.Header]
    }
}

Insert code

try db.run(tableNews.insert(or: OnConflict.Ignore,
    NewsColumn.Id <- (rawNews["id"] as! Int),
    NewsColumn.Header <- (rawNews["name"] as! String),
))

This insert code will fail here if model with the same Id already exists.

[asfdfdfd]

https://www.sqlite.org/c3ref/last_insert_rowid.html

The sqlite3_last_insert_rowid(D) interface returns the rowid of the most recent successful INSERT into a rowid table [...]

An INSERT that fails due to a constraint violation is not a successful INSERT and does not change the value returned by this routine. Thus [...], INSERT OR IGNORE, [...] make no changes to the return value of this routine when their insertion fails.

[ghost]

This method is the culprit, self.lastInsertRowid is nullable, but the return type is Int64.

public func run(query: Insert) throws -> Int64 {
  let expression = query.expression
  return try sync {
    try self.run(expression.template, expression.bindings)
    return self.lastInsertRowid!
  }
}

Temporary fix:

public func run(query: Insert) throws -> Int64 {
  let expression = query.expression
  return try sync {
    try self.run(expression.template, expression.bindings)
    return (self.lastInsertRowid ?? -1)!
  }
}

[asfdfdfd]

Also here is alternative fix, but it was rejected.

[ghost]

I tried that fix, but it does not build for me.

[asfdfdfd]

With my fix you have to check return value on nil. With 'if let' pattern, for example.

[ghost]

True, also I'm not sure how Stephen feels about returning -1 for failed Insert statements. We shall see.

[iNoles]

Since a row id should be unique number with Ignore, any column with -1 wouldn't fix a problem. I think insert methods should just do db.run without lastInsertRowid.

[iNoles]

@stephencelis How about

public func run(query: Insert) throws -> Connection {
        let expression = query.expression
        return try sync {
            try self.run(expression.template, expression.bindings)
            return self
        }
    }

[jberkel]

Fixed in 75394da