-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implements batch insert rows, insertMany() #1048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2021
tests pass locally, somethings not right with Travis CI though |
geoffmacd
pushed a commit
to geoffmacd/SQLite.swift
that referenced
this pull request
May 3, 2021
Fixes #897 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature improvement: ability to insert multiple rows in one statement.
#168
This is something I personally need at dropbox for performance as its more efficient to bind to a single statement rather than recreating many similar INSERT Statements. In my use case, using this improves performance for 1 column string insert from ~0.34 seconds for 10,000 rows in a transaction to ~0.08s for 10,000 rows which is inline (to order of magnitude) with other sqlite benchmarks across the internet like https://medium.com/@JasonWyatt/squeezing-performance-from-sqlite-insertions-971aff98eef2.
Supports all the variations I could see including
Encodable
s and the various syntaxes. There is a slight concern which is that this depends on at least 1 object to find the columns, otherwise, we have to default to some return that makes the API easy to use. eg. it should not return anInsert?
. Suggestions welcome here. Added tests as well.Example usage:
users.insertMany([mail <- "alice@mac.com"], [email <- "geoff@mac.com"])