UUID Fix #1112
Merged
UUID Fix #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upon further investigating I found this was only an issue when I was inserting Codables. I have duplicated the issue by inserting a Codable and then querying the table for the UUID - it won't find it because it will compare an unwrapped UUID to one wrapped in quotes. |
|
Thanks for the PR. Looks like there are still some linting errors. |
|
Ok. Is there something I should run before I push an update? I should
probably look up lint and clean up my code.
…On Mon, Feb 21, 2022 at 2:15 AM Jan Berkel ***@***.***> wrote:
Thanks for the PR. Looks like there are still some linting errors.
—
Reply to this email directly, view it on GitHub
<#1112 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALJFUISZULV4CMDIVFOGTRLU4HYC7ANCNFSM5OY64MWA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Install
|
jberkel
reviewed
Feb 22, 2022
Sources/SQLite/Typed/Coding.swift
Outdated
| @@ -207,6 +207,8 @@ private class SQLiteEncoder: Encoder { | |||
| encoder.setters.append(Expression(key.stringValue) <- data) | |||
| } else if let date = value as? Date { | |||
| encoder.setters.append(Expression(key.stringValue) <- date.datatypeValue) | |||
| } else if let uuid = value as? UUID { | |||
| encoder.setters.append(Expression(key.stringValue) <- uuid.uuidString) | |||
jberkel
reviewed
Feb 22, 2022
| } else { | ||
| XCTFail("Search for uuid failed") | ||
| } | ||
| } |
There was a problem hiding this comment.
the tests should be in QueryTests.swift. Look for test_insert_encodable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inserting a UUID as Expression<UUID> resulted in escaped quotes on either side of the uuidString and thus actual quotes stored inside the DB. When retrieving a row, the result of UUID(uudiString:) returns null when a uuidString with quotes on either side is given.
This appears to be an issue with JSONEncoder.
Fix pre-empts JSONEncoder and inserts a proper uuidString without escaped quotes on either side.