Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Array Unterface for createIndex(_:unique:ifNotExists:) #774

Closed
wants to merge 1 commit into from
Closed

Add Array Unterface for createIndex(_:unique:ifNotExists:) #774

wants to merge 1 commit into from

Conversation

horita-yuya
Copy link

@horita-yuya horita-yuya commented Jan 16, 2018

How about adding array interface for createIndex(_:unique:ifNotExists:), in addition to variadic interface?
Inside variadic function the type of the parameter is Array. But it does not accept Array Type.
Isn't it inconvenient a little bit in using it inside some functions like below?

import SQLite

var table: Table
func Hoge(numberColumns: Int...) {
...
table.createIndex(numberColumns) // Error because of variadic.
...
}

Sincerely,

@kireev4art
Copy link

It is inconvenient and it’s my fault. I tried to remove controversy between documentation and code.
Please see https://github.com/stephencelis/SQLite.swift/blob/master/Documentation/Index.md#indexes and #666 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants