updated Bridging header to be compatible with SQLCipher 4.0.0 pod #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This resolved my Xcode 10 issue with the same error. Looks like it's breaking CI though: module 'SQLCipher' not found Do you know a fix for this @asidden ? For now I plan on using your change with a git patch. |
|
travis is building using Xcode 9, but unfortunately I don't have one to check with it. |
Merged
|
This should work now in master (cf4183f) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
until this change, I was not able to install SQLite.swift with Xcode 10.1 via
SQLCipher dependency pod version resolved - 4.0.0
the build failed with error:
error: include of non-modular header inside framework module 'SQLite.SQLite_Bridging': '/Pods/SQLCipher/sqlite3.h'
#import "sqlite3.h"
however, I'm not sure this change does not affect Carthage or SPM installation.