Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applying Jaime's rotation #5

Open
stephengold opened this issue Sep 7, 2021 · 3 comments
Open

applying Jaime's rotation #5

stephengold opened this issue Sep 7, 2021 · 3 comments

Comments

@stephengold
Copy link
Owner

stephengold commented Sep 7, 2021 •
edited
Loading

At commit: 4cd137d
To reproduce: 4, 1, Apply
Expected: no change in model appearance
Got: light brown zebra stripes on Jaime
Hypothesis: incorrect rotation of tangents and/or normals
@stephengold
Copy link
Owner Author

Omitting the MyMesh.rotateTangentBuffer() invocations in SelectedSpatial.applyTransform() seems to solve this issue.

@stephengold
Copy link
Owner Author

However, it reveals that the bone transforms in the animations need to be transformed as well. Leave this open for now.

stephengold added a commit that referenced this issue Sep 7, 2021
@stephengold
SelectedSpatial: partial fix for issue #5
5033c93
@stephengold
Copy link
Owner Author

Jaime is a particularly tricky case, because the rotation occurs between the SkeletonControl and the Mesh. Perhaps Maud should test for this condition and refuse to apply the transform.

stephengold added a commit that referenced this issue Sep 7, 2021
@stephengold
fix issue #5 (NPE after deleting a MatParam 2x)
4b3c05f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stephengold