Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, it's me again!
I continued profiling and found that the performance issue is still with the same functions.
Methods that work with the head of an array (shift, unshift) are slow operations. So I changed them to work with cursor (index). This insignificantly affects the amount of memory consumed, since only references to objects are stored in the array.
The same benchmark as in my previous PR (#38) showed the following results:
Not so impressive. But on my real input .proto is much better: 2s instead of 6s. This is close enough to how C++ plugins work.
Ts-poet tests are green. Ts-proto integration tests are also green.