fix: Fix bad grpc.Metadata import. Fixes #188. (#259)

* fix: Fix bad grpc.Metadata import. Fixes #188.

* Fix test.

integration/grpc-js/google/protobuf/timestamp.ts

@@ -56,16 +56,7 @@ export const protobufPackage = 'google.protobuf';
  *         .setNanos((int) ((millis % 1000) * 1000000)).build();
  *
  *
- * Example 5: Compute Timestamp from Java `Instant.now()`.
- *
- *     Instant now = Instant.now();
- *
- *     Timestamp timestamp =
- *         Timestamp.newBuilder().setSeconds(now.getEpochSecond())
- *             .setNanos(now.getNano()).build();
- *
- *
- * Example 6: Compute Timestamp from current time in Python.
+ * Example 5: Compute Timestamp from current time in Python.
  *
  *     timestamp = Timestamp()
  *     timestamp.GetCurrentTime()

integration/grpc-js/simple.ts

@@ -1,4 +1,6 @@
 /* eslint-disable */
+import { util, configure, Writer, Reader } from 'protobufjs/minimal';
+import * as Long from 'long';
 import {
   makeGenericClientConstructor,
   ChannelCredentials,
@@ -17,8 +19,6 @@ import {
   ClientDuplexStream,
   ServiceError,
 } from '@grpc/grpc-js';
-import { util, configure, Writer, Reader } from 'protobufjs/minimal';
-import * as Long from 'long';
 import { Timestamp } from './google/protobuf/timestamp';
 import { Empty } from './google/protobuf/empty';
 

integration/grpc-web-no-streaming-observable/example.ts

@@ -5,6 +5,7 @@ import { grpc } from '@improbable-eng/grpc-web';
 import { Observable } from 'rxjs';
 import { BrowserHeaders } from 'browser-headers';
 import { take } from 'rxjs/operators';
+import { Metadata } from 'grpc';
 
 export const protobufPackage = 'rpx';
 
@@ -354,7 +355,7 @@ export const Empty = {
  * but with the streaming method removed.
  */
 export interface DashState {
-  UserSettings(request: DeepPartial<Empty>, metadata?: grpc.Metadata): Observable<DashUserSettingsState>;
+  UserSettings(request: DeepPartial<Empty>, metadata?: Metadata): Observable<DashUserSettingsState>;
 }
 
 export class DashStateClientImpl implements DashState {

integration/grpc-web-no-streaming/example.ts

@@ -3,6 +3,7 @@ import { util, configure, Writer, Reader } from 'protobufjs/minimal';
 import * as Long from 'long';
 import { grpc } from '@improbable-eng/grpc-web';
 import { BrowserHeaders } from 'browser-headers';
+import { Metadata } from 'grpc';
 
 export const protobufPackage = 'rpx';
 
@@ -352,7 +353,7 @@ export const Empty = {
  * but with the streaming method removed.
  */
 export interface DashState {
-  UserSettings(request: DeepPartial<Empty>, metadata?: grpc.Metadata): Promise<DashUserSettingsState>;
+  UserSettings(request: DeepPartial<Empty>, metadata?: Metadata): Promise<DashUserSettingsState>;
 }
 
 export class DashStateClientImpl implements DashState {

integration/grpc-web/example.ts

@@ -5,6 +5,7 @@ import { grpc } from '@improbable-eng/grpc-web';
 import { Observable } from 'rxjs';
 import { BrowserHeaders } from 'browser-headers';
 import { share } from 'rxjs/operators';
+import { Metadata } from 'grpc';
 
 export const protobufPackage = 'rpx';
 
@@ -730,8 +731,8 @@ export const Empty = {
 };
 
 export interface DashState {
-  UserSettings(request: DeepPartial<Empty>, metadata?: grpc.Metadata): Promise<DashUserSettingsState>;
-  ActiveUserSettingsStream(request: DeepPartial<Empty>, metadata?: grpc.Metadata): Observable<DashUserSettingsState>;
+  UserSettings(request: DeepPartial<Empty>, metadata?: Metadata): Promise<DashUserSettingsState>;
+  ActiveUserSettingsStream(request: DeepPartial<Empty>, metadata?: Metadata): Observable<DashUserSettingsState>;
 }
 
 export class DashStateClientImpl implements DashState {
@@ -804,9 +805,9 @@ export const DashStateActiveUserSettingsStreamDesc: UnaryMethodDefinitionish = {
  * ----------------------
  */
 export interface DashAPICreds {
-  Create(request: DeepPartial<DashAPICredsCreateReq>, metadata?: grpc.Metadata): Promise<DashCred>;
-  Update(request: DeepPartial<DashAPICredsUpdateReq>, metadata?: grpc.Metadata): Promise<DashCred>;
-  Delete(request: DeepPartial<DashAPICredsDeleteReq>, metadata?: grpc.Metadata): Promise<DashCred>;
+  Create(request: DeepPartial<DashAPICredsCreateReq>, metadata?: Metadata): Promise<DashCred>;
+  Update(request: DeepPartial<DashAPICredsUpdateReq>, metadata?: Metadata): Promise<DashCred>;
+  Delete(request: DeepPartial<DashAPICredsDeleteReq>, metadata?: Metadata): Promise<DashCred>;
 }
 
 export class DashAPICredsClientImpl implements DashAPICreds {

integration/only-types-grpc-metadata/only-types-grpc-metadata-test.ts

@@ -0,0 +1,8 @@
+import { GetBasicRequest } from './only-types-grpc-metadata';
+
+describe('BasicService', () => {
+  it('compiles', () => {
+    const g: GetBasicRequest = { name: 'asdf' };
+    expect(g).toBeTruthy();
+  });
+});

integration/only-types-grpc-metadata/only-types-grpc-metadata.proto

@@ -0,0 +1,14 @@
+syntax = "proto3";
+package basic;
+
+message GetBasicRequest {
+  string name = 1;
+}
+
+message GetBasicResponse {
+  string name = 1;
+}
+
+service BasicService {
+  rpc GetBasic (GetBasicRequest) returns (GetBasicResponse) {}
+}

integration/only-types-grpc-metadata/only-types-grpc-metadata.ts

@@ -0,0 +1,16 @@
+/* eslint-disable */
+import { Metadata } from 'grpc';
+
+export const protobufPackage = 'basic';
+
+export interface GetBasicRequest {
+  name: string;
+}
+
+export interface GetBasicResponse {
+  name: string;
+}
+
+export interface BasicService {
+  getBasic(request: GetBasicRequest, metadata?: Metadata): Promise<GetBasicResponse>;
+}

integration/only-types-grpc-metadata/parameters.txt

@@ -0,0 +1 @@
+outputEncodeMethods=false,outputJsonMethods=false,outputClientImpl=false,lowerCaseServiceMethods=true,addGrpcMetadata=true

integration/type-registry/google/protobuf/timestamp.ts

@@ -57,16 +57,7 @@ export const protobufPackage = 'google.protobuf';
  *         .setNanos((int) ((millis % 1000) * 1000000)).build();
  *
  *
- * Example 5: Compute Timestamp from Java `Instant.now()`.
- *
- *     Instant now = Instant.now();
- *
- *     Timestamp timestamp =
- *         Timestamp.newBuilder().setSeconds(now.getEpochSecond())
- *             .setNanos(now.getNano()).build();
- *
- *
- * Example 6: Compute Timestamp from current time in Python.
+ * Example 5: Compute Timestamp from current time in Python.
  *
  *     timestamp = Timestamp()
  *     timestamp.GetCurrentTime()

src/generate-nestjs.ts

@@ -14,6 +14,8 @@ import { maybeAddComment, singular } from './utils';
 import { camelCase } from './case';
 import { Context } from './context';
 
+const Metadata = imp('Metadata@grpc');
+
 export function generateNestjsServiceController(
   ctx: Context,
   fileDesc: FileDescriptorProto,
@@ -41,7 +43,7 @@ export function generateNestjsServiceController(
     // Use metadata as last argument for interface only configuration
     if (options.addGrpcMetadata) {
       const q = options.addNestjsRestParameter ? '' : '?';
-      params.push(code`metadata${q}: ${imp('Metadata@grpc')}`);
+      params.push(code`metadata${q}: ${Metadata}`);
     }
     if (options.addNestjsRestParameter) {
       params.push(code`...rest: any`);
@@ -114,7 +116,7 @@ export function generateNestjsServiceClient(
     // Use metadata as last argument for interface only configuration
     if (options.addGrpcMetadata) {
       const q = options.addNestjsRestParameter ? '' : '?';
-      params.push(code`metadata${q}: ${imp('Metadata@grpc')}`);
+      params.push(code`metadata${q}: ${Metadata}`);
     }
     if (options.addNestjsRestParameter) {
       params.push(code`...rest: any`);

src/generate-services.ts

@@ -21,6 +21,7 @@ import { Context } from './context';
 const hash = imp('hash*object-hash');
 const dataloader = imp('DataLoader*dataloader');
 const Reader = imp('Reader@protobufjs/minimal');
+const Metadata = imp('Metadata@grpc');
 
 /**
  * Generates an interface for `serviceDesc`.
@@ -66,10 +67,10 @@ export function generateService(
 
     // Use metadata as last argument for interface only configuration
     if (options.outputClientImpl === 'grpc-web') {
-      params.push(code`metadata?: grpc.Metadata`);
+      params.push(code`metadata?: ${Metadata}`);
     } else if (options.addGrpcMetadata) {
       const q = options.addNestjsRestParameter ? '' : '?';
-      params.push(code`metadata${q}: Metadata@grpc`);
+      params.push(code`metadata${q}: ${Metadata}`);
     }
     if (options.addNestjsRestParameter) {
       params.push(code`...rest: any`);