Maps with enum values do not generate fromJSON/fromPartial correctly when stringEnums=true

[wrobbinz]

When stringEnums flag is set to true, the generated types for a map<string, T> (where T is an enum) do not generate correctly. It seems that the generated code is not respecting that stringEnums=true and is assuming the value is a number.

TS2322: Type 'number' is not assignable to type 'SomeEnumType'.

Example:

Input

enum SomeEnumType {
  UNDEFINED_SOME_ENUM_TYPE = 0;
  DEFINED_SOME_ENUM_TYPE = 1;
}

message Entity {
  map<string, SomeEnumType> parameters = 1;
}

Output

export enum SomeEnumType {
  UNDEFINED_SOME_ENUM_TYPE = 'UNDEFINED_SOME_ENUM_TYPE',
  DEFINED_SOME_ENUM_TYPE = 'DEFINED_SOME_ENUM_TYPE',

}

export interface Entity {
  parameters: { [key: string]: SomeEnumType };
}

// Entity
fromJSON(object: any): Entity {
    const message = { ...baseEntity } as Entity;

    if (object.parameters !== undefined && object.parameters !== null) {
      Object.entries(object.parameters).forEach(([key, value]) => {
        message.parameters[key] = value as number; // <-- error is here
      });
    }

[stephenh]

🎉 This issue has been resolved in version 1.109.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀