struct unwrap fails TypeScript's noImplicitReturns check

[absoludity]

Since 1.88.0 was released, the code to unwrap a struct has failed TypeScript's noImplicitReturns check, which is normally a sane check to have on.

In 1.88.0, the function unwrapAnyValue was added, without an explicit return (even though you may know one of the conditionals is guaranteed to be true), resulting in:

src/gen/google/protobuf/struct.ts:415:4 - error TS7030: Not all code paths return a value.

415 ): string | number | boolean | Object | null | Array<any> | undefined {
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This is still the case, though in a slightly different form in the latest 1.91, still resulting in the lint error:

src/gen/google/protobuf/struct.ts:397:6 - error TS7030: Not all code paths return a value.

397   ): string | number | boolean | Object | null | Array<any> | undefined {
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[stephenh]

@boukeversteegh hm, wdyt about this issue? Should Value.unwrap have a final return undefined or a throw new Error("Unhandled message ${message}");.

[boukeversteegh]

@stephenh I think undefined should be returned at the end. This matches the signature, and it's not really an error for a Value object to be empty. It internally contains a one-of field, and afaik there's no guarantee that exactly one field is set, so it may fall through the if/else branches.

I also see that value is not checked for null or empty. I suppose someone could construct a protobuf message that decoded into an object with a Value field which is unset, so it is technically possible to trigger an error.

As I'm on holiday now, I don't have a good setup to work on ts-proto, but I'll try a PR from the github editor to fix these two issues.

[stephenh]

🎉 This issue has been resolved in version 1.92.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀