Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: noImplicitReturns error in Value.unwrap #436

Merged
merged 5 commits into from
Dec 8, 2021
Merged

fix: noImplicitReturns error in Value.unwrap #436

merged 5 commits into from
Dec 8, 2021

Conversation

boukeversteegh
Copy link
Collaborator

Fixes #432

@boukeversteegh boukeversteegh changed the title fix noImplicitReturns error in Value.unwrap fix: noImplicitReturns error in Value.unwrap Dec 8, 2021
@boukeversteegh
Copy link
Collaborator Author

boukeversteegh commented Dec 8, 2021

Thanks to the dockerization, I was able to easily run the scripts on a holiday laptop. However, automatic line-conversion made the shell script use CRLF instead of LF, which is OK when running bash on windows, but within docker, Linux tripped over those, so I added a .gitattributes file that makes sure that all .sh scripts are always checked out as LF. This is cross-platform compatible.

  • Update: had to do the same for parameters.txt. When checked out with CRLF, the params would not be passed. (linux interprets \r as clearing the line from start till cursor, so \r\n removes the parameters)

@stephenh
Copy link
Owner

stephenh commented Dec 8, 2021

Thanks to the dockerization, I was able to easily run the scripts on a holiday laptop

💯

so I added a .gitattributes file

Ah nice, good idea!

@stephenh stephenh merged commit 2d7a5d0 into main Dec 8, 2021
@stephenh stephenh deleted the fix/432 branch December 8, 2021 15:22
stephenh pushed a commit that referenced this pull request Dec 8, 2021
## [1.92.2](v1.92.1...v1.92.2) (2021-12-08)

### Bug Fixes

* noImplicitReturns error in Value.unwrap ([#436](#436)) ([2d7a5d0](2d7a5d0)), closes [#432](#432)
@stephenh
Copy link
Owner

stephenh commented Dec 8, 2021

🎉 This PR is included in version 1.92.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

struct unwrap fails TypeScript's noImplicitReturns check
2 participants