Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Type Error when map contains string enums #382 #529

Merged
merged 4 commits into from
Mar 13, 2022
Merged

fix: Type Error when map contains string enums #382 #529

merged 4 commits into from
Mar 13, 2022

Conversation

boukeversteegh
Copy link
Collaborator

@boukeversteegh boukeversteegh commented Mar 7, 2022 •
edited
Loading

Fixes #382

@boukeversteegh boukeversteegh marked this pull request as ready for review March 7, 2022 13:40
@boukeversteegh boukeversteegh requested a review from stephenh March 7, 2022 13:40
stephenh
stephenh reviewed Mar 13, 2022
View reviewed changes
src/main.ts Show resolved Hide resolved
stephenh
stephenh approved these changes Mar 13, 2022
View reviewed changes
Copy link
Owner

@stephenh stephenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boukeversteegh looks great!

@stephenh stephenh merged commit c2107b9 into main Mar 13, 2022
@stephenh stephenh deleted the fix/382 branch March 13, 2022 17:35
stephenh pushed a commit that referenced this pull request Mar 13, 2022
@semantic-release-bot
chore(release): 1.109.1 [skip ci]
b8a4e7e 
## [1.109.1](v1.109.0...v1.109.1) (2022-03-13)

### Bug Fixes

* Type Error when map contains string enums [#382](#382) ([#529](#529)) ([c2107b9](c2107b9))
@stephenh
Copy link
Owner

🎉 This PR is included in version 1.109.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stephenh stephenh mentioned this pull request Apr 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenh stephenh stephenh approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maps with enum values do not generate fromJSON/fromPartial correctly when stringEnums=true
2 participants
@boukeversteegh @stephenh