Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repeated uint64 fields do not encode properly with bigint option #751

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

azizghuloum
Copy link
Contributor

@azizghuloum azizghuloum commented Jan 4, 2023

fixes #749

@azizghuloum azizghuloum changed the title Fix: repeated uint64 fields do not encode properly with bigint option fix: repeated uint64 fields do not encode properly with bigint option Jan 4, 2023
@stephenh
Copy link
Owner

stephenh commented Jan 9, 2023

This is great, thanks @azizghuloum !

@stephenh
Copy link
Owner

stephenh commented Jan 9, 2023

(I also went ahead and added a regression test before merging)

@stephenh stephenh merged commit dcdd7e2 into stephenh:main Jan 9, 2023
stephenh pushed a commit that referenced this pull request Jan 9, 2023
## [1.137.2](v1.137.1...v1.137.2) (2023-01-09)

### Bug Fixes

* repeated uint64 fields do not encode properly with bigint option ([#751](#751)) ([dcdd7e2](dcdd7e2))
@stephenh
Copy link
Owner

stephenh commented Jan 9, 2023

🎉 This PR is included in version 1.137.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--forceLong=bigint doesn't handle array of int64 correctly
2 participants