-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option for remove toJSON #859
Comments
Hi @f0rmat1k , sure if you wanted to add support for |
Hi! I didn't read this issue but I've managed to do the same thing! |
Frabat
added a commit
to Frabat/ts-proto
that referenced
this issue
Jul 18, 2023
Frabat
added a commit
to Frabat/ts-proto
that referenced
this issue
Jul 18, 2023
feat(ts-proto-stephenh#859): added encode-only options to toJSON methods
Frabat
pushed a commit
to Frabat/ts-proto
that referenced
this issue
Jul 18, 2023
Frabat
pushed a commit
to Frabat/ts-proto
that referenced
this issue
Jul 19, 2023
stephenh
pushed a commit
that referenced
this issue
Jul 20, 2023
* feat(ts-proto-#859): added encode-only options to toJSON methods * feat(ts-proto-#859): fixed error in implementation * feat(ts-proto#859): inverted fromJSON and toJSON methods to avoid changing all tests * feat(ts-proto#859): ran yarn format * feat(ts-proto-#859): updated docs and renamed methods to toOnly and fromOnly --------- Co-authored-by: Francesco Battista <francesco.battista@nbcuni.com>
stephenh
pushed a commit
that referenced
this issue
Jul 20, 2023
# [1.156.0](v1.155.1...v1.156.0) (2023-07-20) ### Features * **ts-proto-#859:** added encode-only options to toJSON methods ([#886](#886)) ([d0cf57d](d0cf57d)), closes [ts-proto-#859](https://github.com/ts-proto-/issues/859) [ts-proto-#859](https://github.com/ts-proto-/issues/859) [ts-proto#859](https://github.com/ts-proto/issues/859) [ts-proto#859](https://github.com/ts-proto/issues/859) [ts-proto-#859](https://github.com/ts-proto-/issues/859)
stephenh
pushed a commit
that referenced
this issue
Sep 3, 2023
* feat(ts-proto-#859): added encode-only options to toJSON methods * feat(ts-proto-#859): fixed error in implementation * feat(ts-proto#859): inverted fromJSON and toJSON methods to avoid changing all tests * feat(ts-proto#859): ran yarn format * feat(ts-proto-#859): updated docs and renamed methods to toOnly and fromOnly * feat: removed toJson/fromJSON enums when not used * feat(#909): ran format --------- Co-authored-by: Francesco Battista <francesco.battista@nbcuni.com>
stephenh
pushed a commit
that referenced
this issue
Sep 3, 2023
# [1.157.0](v1.156.8...v1.157.0) (2023-09-03) ### Features * enum decoding ([#910](#910)) ([9e0a0b5](9e0a0b5)), closes [ts-proto-#859](https://github.com/ts-proto-/issues/859) [ts-proto#859](https://github.com/ts-proto/issues/859) [ts-proto#859](https://github.com/ts-proto/issues/859) [ts-proto-#859](https://github.com/ts-proto-/issues/859) [#909](#909)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is no option, to remove
toJSON
from output. Only both with--ts_proto_opt=outputJsonMethods=false
. We are using tool on the client and we need onlyfromJSON
there. It would be nice to have option about removing toJSON (or only fromJOSN). I can try to send PR, if you don't mindThe text was updated successfully, but these errors were encountered: