map<string, google.protobuf.Timestamp> produces invalid fromJson and fromPartial code

[mscolnick]

If this was added to SimpleWithMap

message SimpleWithMap {
  map<int32, Entity> entitiesById = 1;
  map<string, string> nameLookup = 2;
  map<int32, int32> intLookup = 3;
+ map<string, google.protobuf.Timestamp> mapOfTimestamps = 4;
}

The output will generate the map entry to be Date.fromJSON and Date.fromPartial:

export const SimpleWithMap = {
fromJSON(object: any): SimpleWithMap {
  ...
  if (object.mapOfTimestamps !== undefined && object.mapOfTimestamps !== null) {
    Object.entries(object.mapOfTimestamps).forEach(([key, value]) => {
      message.mapOfTimestamps[key] = Date.fromJSON(value); // Property 'fromJSON' does not exist on type 'DateConstructor'
    })
  }
  return message;
},

fromPartial(object: DeepPartial<SimpleWithMap>): SimpleWithMap {
  ...
  if (object.mapOfTimestamps !== undefined && object.mapOfTimestamps !== null) {
    Object.entries(object.mapOfTimestamps).forEach(([key, value]) => {
      if (value !== undefined) {
        message.mapOfTimestamps[key] = Date.fromPartial(value); // Property 'fromPartial' does not exist on type 'DateConstructor'
      }
    })
  }
  return message;
},
}

[stephenh]

Hm, thanks for the report and great repro. I'll poke around when I get a chance...

[stephenh]

Well, it took awhile to get a weekend hack morning on this, but this will be fixed in the next release. Thanks for the report!

[mscolnick]

amazing, thank you very much!