fix: import fails when folder name overlaps with file name #1000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR shows the error that occurs when the a proto file imports a file named the same thing as its containing folder.
Example of the old codegen behavior
Example:
This results in generated Typescript such as:
This is not valid Typescript.
If you use the
fileSuffix
orimportSuffix
options, this issue disappears.Fix
This PR in
ts-poet
fixes the issue