Add support for 'json_name' annotation. #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenh
reviewed
Feb 12, 2021
| export const protobufPackage = 'simple'; | ||
|
|
||
| export interface Simple { | ||
| other_name: string; |
There was a problem hiding this comment.
Hm, my interpretation of json_name attribute would be that this particular name would still be name and then other_name would only show up on the JSON on the wire (i.e. in toJson methods) and then looked for when data is parsed in from the wire (i.e. in the fromJson methods).
Can we do that instead?
|
Fixed in #408 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
json_nameannotation.I went through calls to
maybeSnakeToCameland replaced it with calls to a new function calledgetFieldName, which will additionally inspect thejsonNamefield ofFieldDescriptorProto.A simple integration test is added as well.
I decided to not add a configurable option for this right now, but it would be trivial to do so.
According to the proto3 language guide parsers should to handle different field names:
As this currently does not seem to be implemented, I also skipped it for the
json_namesupport.