feat: Reduce code size by using nullish coalescing operator in fromPartial #376
Conversation
| } else { | ||
| message.numberField = 0; | ||
| { | ||
| message.numberField = object.numberField ?? 0; | ||
| } |
There was a problem hiding this comment.
This block is not needed in the output code. However, I can't get it to work without it.
src/main.ts
Outdated
| isValueType(ctx, field) | ||
| ) { | ||
| // An optimized case of the else below that works when `readSnippet` returns the plain input | ||
| chunks.push(code`{`); // Without this extra scope the code generation breaks 🤷. We don't really need it. |
There was a problem hiding this comment.
Any clue why thi line is needed? Without it the code generation breaks compeltely.
There was a problem hiding this comment.
@webmaster128 wow, that was weird. I pushed a commit to this PR that re-fiddled with the braces in fromPartial. I'm not really sure how it was working before :-) but I think it's straightened out now.
There was a problem hiding this comment.
Ah, very nice, thanks. I thought there is some magic in the code generator such that braces are not supposed to be closed manually. Now it's clearer.
webmaster128
force-pushed
the
organize-intitializers
branch
from
2b28dc5
to
ab60a28
Compare
webmaster128
force-pushed
the
organize-intitializers
branch
from
6f01de5
to
ea653c0
Compare
|
Alright, I'm happy with this now. In https://github.com/confio/cosmjs-types/pull/11/files you see what this change means for the code generated larger projects. Rebased onto current main branch. How do you want this to be released? Is this a feature or a fix? |
webmaster128
force-pushed
the
organize-intitializers
branch
from
ea653c0
to
3af7913
Compare
There was a problem hiding this comment.
@webmaster128 looks great! Much cleaner! Yeah, releasing as a feature sgtm.
|
Thanks :) |
# [1.84.0](v1.83.3...v1.84.0) (2021-11-02) ### Features * Reduce code size by using nullish coalescing operator in fromPartial ([#376](#376)) ([19d2ded](19d2ded))
|
🎉 This PR is included in version 1.84.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #371
Builds on #375 (merge that first, then rebase)