Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin ts-proto-descriptors to 1.3.1. #481

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Conversation

stephenh
Copy link
Owner

@stephenh stephenh commented Jan 19, 2022

Fixes #480

Per discussion here:

#479 (comment)

Because of oneofIndex=0 being ambiguous about "is this set? or is this the first oneof?" and ts-proto's current like of hazzer methods, we need to pin to a specific version of ts-proto-descriptors that was built with temporary hazzer functionality that has since been reverted.

@stephenh stephenh merged commit 6f362bf into main Jan 19, 2022
@stephenh stephenh deleted the pin-ts-proto-descriptors branch January 19, 2022 14:24
stephenh pushed a commit that referenced this pull request Jan 19, 2022
## [1.102.1](v1.102.0...v1.102.1) (2022-01-19)

### Bug Fixes

* Pin ts-proto-descriptors to 1.3.1. ([#481](#481)) ([6f362bf](6f362bf)), closes [#480](#480)
@stephenh
Copy link
Owner Author

🎉 This PR is included in version 1.102.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

option oneof=unions causing error Cannot read properties of undefined (reading 'name')
1 participant