feat: Support json names containing non-alphanumeric characters #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenh
approved these changes
Feb 21, 2022
|
Haha wow, that was fast. Thanks so much! |
stephenh
pushed a commit
that referenced
this pull request
Feb 21, 2022
# [1.106.0](v1.105.2...v1.106.0) (2022-02-21) ### Features * Support json names containing non-alphanumeric characters ([#520](#520)) ([ce44668](ce44668))
|
🎉 This PR is included in version 1.106.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a protobuf definition that needed to match an external JSON format, which contains the property
error-codes(with hyphen):This compiled into the following invalid TypeScript:
This PR fixes that issue.
It will use array-syntax for all properties that don't follow the format
(letter /underscore / dollar) + (letter / number / underscore / $).Technically, ecma allows many more patterns than this, but that regex is insane, and it's not such a problem to over-use the bracket syntax, in my opinion.
This PR also includes a fix for a bug in the
watchtask. There was an error in the chokidar event handler (signature is different when watchingallas compared tochange.) Hope that's ok.