fix: internal packages now takes suffix and esm opt. #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paralin
requested changes
Jul 14, 2022
|
I'll fix the lint. |
paralin
approved these changes
Jul 15, 2022
|
@siendoricardo Squashed your commits to 1 commit & added some more info in the commit description, also fixed some CI errors (ran @stephenh This looks good to me. |
Add a new impFile function which uses the importSuffix to import. Use impFile for protobufjs/minimal such that; If importSuffix='.js' then: import * as _m1 from 'protobufjs/minimal.js'; Fixes esmodule interop. Adjust ts-poet options to fix importing the default module from protobufjs/minimal.js if necessary.
stephenh
pushed a commit
that referenced
this pull request
Jul 16, 2022
## [1.117.1](v1.117.0...v1.117.1) (2022-07-16) ### Bug Fixes * import protobufjs/minimal with importSuffix ([#616](#616)) ([b86291c](b86291c))
|
🎉 This PR is included in version 1.117.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: #615