Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tldr: envoy uses nghttp2, which reports
invalid frame: Violation in HTTP messaging rule on stream 1
Long Story: If you use this example in a server node.js process in Kubernetes with an Istio Service Mesh, envoy will report something like
if you try to call an gRPC request. Sadly, there is basically no documentation at all available for this behaviour.
The
Promise
will reject withConnection dropped
and no other details.Prepending the
/
to the path ensures that the behaviour is not violating the HTTP/2 standard, because appearently node http2 package does allow the path to not start with/
.See https://www.rfc-editor.org/rfc/rfc7540#section-8.1.2 8.1.2.3 and https://www.rfc-editor.org/rfc/rfc3986#section-3.3
If you develop locally against a different gRPC server, such as the go grpc implementation, this error does not occur, go will accept the missing
/
and simply work.Thank you for this great project, really appreciate your work!