feat: add a no-tags option to the type-registry #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fizx
changed the title
added 10 commits
October 19, 2022 13:26
stephenh
reviewed
Oct 23, 2022
There was a problem hiding this comment.
I think other than the *.bin issue this PR lgtm! Let me know if running yarn proto2bin with dockers gets them fixed up. If not, we can either figure out how to get the M1 docker output consistent, or I can just revert the *.bin changes directly on this branch/something like that.
| @@ -688,15 +692,15 @@ export function responseType( | |||
| methodDesc: MethodDescriptorProto, | |||
| typeOptions: { keepValueType?: boolean; repeated?: boolean } = {} | |||
There was a problem hiding this comment.
Looks like the typeOptions param is not used anymore? Lets just drop it if so?
| } | ||
| // if (options.useDate && rawOutputType.toString().includes("Timestamp")) { | ||
| // decode = code`data => ${utils.fromTimestamp}(${rawOutputType}.decode(new ${Reader}(data)))`; | ||
| // } |
There was a problem hiding this comment.
I assume this is related to #689 , just checking that you wanted to include commenting out this code in this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The $types are getting in the way of usability of the code we're writing, but the registry itself is useful.