perf: generate switch statement for oneof union encode #767
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
encode
method to generate aswitch
statement for oneof unions. These are currently generating asif
statements for every possible$case
so not great for performance as the number of cases grows.In our usage scenario we have a oneof with 160+ cases, which is currently generating 160+
if
statements and duringencode
each is evaluated!!!From benchmarking against our internal
.proto
message definition theswitch
version achieves ~2.8x better performance over the currentif
version.Before
After