Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update fromPartial and fromJson to respect initializeFieldsAsUndefined #811

Merged
merged 3 commits into from
Mar 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions integration/from-partial-no-initialize/parameters.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
useOptionals=all,initializeFieldsAsUndefined=false
50 changes: 50 additions & 0 deletions integration/from-partial-no-initialize/partials-test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
import { TPartial } from './test'

describe('partials-test', () => {
it('works with singular fields', () => {
const test = {
number: 2,
string: 'hi',
message: {
field: 'hello'
}
};

const result = TPartial.fromPartial(test);

expect(result).toEqual(test);
});

it('works with repeated fields', () => {
const test = {
map: {
a: 'b',
c: 'd'
},

repeatedMessage: [
{
field: 'world'
},
{
field: 'hello'
}
],

repeatedString: [
'goodbye',
'world'
],

repeatedNumber: [
1,
2,
3
]
};

const result = TPartial.fromPartial(test);

expect(result).toEqual(test);
});
})
Binary file not shown.
15 changes: 15 additions & 0 deletions integration/from-partial-no-initialize/test.proto
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
syntax = "proto2";

message TPartialMessage{
required string field = 1;
}

message TPartial{
optional int32 number = 1;
optional string string = 2;
map<string, string> map = 3;
optional TPartialMessage message = 4;
repeated TPartialMessage repeated_message = 5;
repeated string repeated_string = 6;
repeated int32 repeated_number = 7;
}
Loading