feat: add unrecognizedEnumName and unrecognizedEnumValue options
#946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vecerek
force-pushed
the
extend-unrecognized-enum-options
branch
from
5eaeb5e to
9d962df
Compare
vecerek
force-pushed
the
extend-unrecognized-enum-options
branch
from
9d962df to
9e64722
Compare
stephenh
approved these changes
Oct 10, 2023
| @@ -32,17 +32,21 @@ export function generateEnum( | |||
| const info = sourceInfo.lookup(Fields.enum.value, index); | |||
| const valueName = getValueName(ctx, fullName, valueDesc); | |||
| const memberName = getMemberName(ctx, enumDesc, valueDesc); | |||
| if (valueDesc.number === options.unrecognizedEnumValue) { | |||
| unrecognizedEnum = { present: true, name: memberName }; | |||
stephenh
pushed a commit
that referenced
this pull request
Oct 10, 2023
# [1.161.0](v1.160.0...v1.161.0) (2023-10-10) ### Features * add unrecognizedEnumName and unrecognizedEnumValue options ([#946](#946)) ([cd61e90](cd61e90))
|
🎉 This PR is included in version 1.161.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #944.