Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override domainBaseUrl per Notion recommendation #109

Closed
wants to merge 2 commits into from
Closed

Override domainBaseUrl per Notion recommendation #109

wants to merge 2 commits into from

Conversation

laughnan
Copy link

@laughnan laughnan commented Aug 14, 2021 •
edited
Loading

Recommended fix from Ryo (Notion on Reddit) and @wentin in the issue queue.

Screen Shot 2021-08-13 at 23 02 16

@vercel
Copy link

vercel bot commented Aug 14, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

csb-vydqj – ./

🔍 Inspect: https://vercel.com/stephenou/csb-vydqj/ABmQtSLnJReLQffrGcd8ceHP3HVy
✅ Preview: https://csb-vydqj-git-fork-laughnan-override-domainbaseurl-stephenou.vercel.app

fruition – ./

🔍 Inspect: https://vercel.com/stephenou/fruition/JC3sedK8sCbmthqmcn5dXbCDo89w
✅ Preview: https://fruition-git-fork-laughnan-override-domainbaseurl-stephenou.vercel.app

@laughnan laughnan mentioned this pull request Aug 14, 2021
Open
laughnan
laughnan commented Aug 14, 2021
View reviewed changes
src/code.js
class BodyRewriter {
constructor(SLUG_TO_PAGE) {
this.SLUG_TO_PAGE = SLUG_TO_PAGE;
}
element(element) {
element.append(\`<div style="display:none">Powered by <a href="http://fruitionsite.com">Fruition</a></div>
<script>
window.CONFIG.domainBaseUrl = "https://\${MY_DOMAIN}";
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the noise (my IDE cleaned up the whitespace). Here is the change for code.js

@tamagamis
Copy link

the corrections work for me

@laughnan
Copy link
Author

Closing this PR since @stephenou included it in their latest commit 🎉 8b1f7dc

@laughnan laughnan closed this Aug 14, 2021
@joshsabol46
Copy link

I'm still experiencing this as of Oct 4, 21.

Reported my issue here: #113 (comment)

CC: @laughnan @sweethuman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweethuman sweethuman sweethuman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laughnan @tamagamis @joshsabol46 @sweethuman