Use SSE4_CRC32 v4 to support node.js v4 and above #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of the fast-crc32c library doesn't allow the hash-stream-validation module to work on node.js v4+ due to its dependency on an older version that does not use Nan v2 (which is required for node.js add-ons to work on node.js v4 and above). This commit brings node.js v4 support to the hash-stream-validation libary.
|
@anandsuresh Am I missing something? See #3, #2 (comment), ashi009/node-fast-crc32c#3 |
|
Nope! I didn't see ashi009/node-fast-crc32c#3. That seems to fix the issues. Someone sent me a debug log that was showing issues with the sse4_crc32 module as a dependency of fast-crc32c, which is what kick started this whole investigation. I was concerned that the indirect dependency on sse4_crc32 was the cause. The changes you have already merged seem to be fine. Closing this now. Sorry for all the confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of the fast-crc32c library doesn't allow the hash-stream-validation
module to work on node.js v4+ due to its dependency on an older version that
does not use Nan v2 (which is required for node.js add-ons to work on node.js v4
and above).
This commit brings node.js v4 support to the hash-stream-validation libary.