Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customDatesStyle prop does not update #245

Closed
HugoChengMyC opened this issue Oct 21, 2020 · 5 comments
Closed

customDatesStyle prop does not update #245

HugoChengMyC opened this issue Oct 21, 2020 · 5 comments

Comments

@HugoChengMyC
Copy link

Trying to update the customDatesStyle prop after a onClick event, but it does not take in the new prop changes. the calendar renders though

@yousefhossein
Copy link

yousefhossein commented Oct 22, 2020 via email

@HugoChengMyC
Copy link
Author

im not sure, but the customDatesStyles only updates after clicking twice

@HugoChengMyC
Copy link
Author

Hi I solve the problem in 1 year ago در تاریخ پنجشنبه ۲۲ اکتبر ۲۰۲۰،‏ ۱:۵۹ HugoChengMyC notifications@github.com نوشت:

Trying to update the customDatesStyle prop after a onClick event, but it does not take in the new prop changes. the calendar renders though — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#245>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMSLBTO7YID32CMT7MVESDLSL5OF7ANCNFSM4S2MIDKQ .

wheres the solution ?

@peacechen
Copy link
Collaborator

componentDidUpdate needs to check whether customDatesStyles has changed and update accordingly. Please submit a PR to fix this bug.

@peacechen
Copy link
Collaborator

The fix has been published in 7.0.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants