Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More day options for start of the week #266

Closed
elliscwc opened this issue Jan 27, 2021 · 3 comments · Fixed by #271
Closed

More day options for start of the week #266

elliscwc opened this issue Jan 27, 2021 · 3 comments · Fixed by #271

Comments

@elliscwc
Copy link
Contributor

thanks for the wonderful calendar picker

I would like to request a feature so that picker can show start of the week for any days instead of just Monday, currently the picker supports startFromMonday but it is kind of limit what the user can do.
@peacechen
Copy link
Collaborator

Please submit a PR to add that feature. Take a look at how startFromMonday is implemented, and you should be able to enhance that to start from any day of the week.

@elliscwc elliscwc mentioned this issue Mar 2, 2021
Merged
peacechen pushed a commit that referenced this issue Mar 8, 2021
@elliscwc
* Add firstDay prop to start week on any day (#271, #266)
1c869e8 
* Preserves `startFromMonday` prop
peacechen pushed a commit that referenced this issue Mar 8, 2021
@elliscwc @peacechen
Add firstDay prop to start week on any day (#271, #266)
159c796 
Preserves `startFromMonday` prop
@peacechen
Copy link
Collaborator

Published in 7.1.1

@elliscwc
Copy link
Contributor Author

thanks @peacechen 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

First day option elliscwc/CalendarPicker
2 participants
@peacechen @elliscwc