Fix issue with editing scroller style on update #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mgmolisani for fixing this. I agree, typing would be beneficial. The project was not originally set up for that and no one has had time to refactor. It would be much appreciated if you or anyone else has the resources to take that on. |
|
Published in 7.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I think there are some bigger issues behind how the styles for the calendar are being set (derived state and whatnot), this fixes an issue where, on update of scroller style props, the scroller could render
nullasheightwasundefined. Root cause seems to be not passing the right argument to theupdateLayouthelper causing the helper to not create required styles. I observed this when using a parent'sonLayoutto dynamically set the width of the calendar causing the update after the callback was triggered.Side note: I want to urge the use of TS in this project if ever possible as this bug could have been totally avoided with strong types.