Missing-observation-autocomplete #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I can't see how just adding types could have led to this failure? As far as I can tell, Demo is not even used in the failing test, although there are some observations used. Cheers FAILED tests/unit/test_environment.py::TestEnvironment::test_action_mode_delta_erj_ik_world_frame - rlbench.backend.exceptions.InvalidActionError: Could not perform IK via Jacobian; most likely due to current end-effector pose being too far from the given target pose. Try limiting/bounding your action space. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is my first pull request, i just notices there is no autocomplete while using the Demo object and adding these types solved that.
Thanks gave a good day