-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy / CDN Config Implementation w/ tests #179
base: master
Are you sure you want to change the base?
Conversation
Implementing proxy.
TypeError: Failed to fetch
ae782b6
to
193b27b
Compare
I'm looking forward it |
Thanks for the poke. I think i finished this before, but i guess i have to re-merge due to the force push |
@stereobooster any chance this might get added?
React-snap is really great, but this feature is missing. I'm aware it wasn't requested a lot, but the issue related to this is from 2 Jan 2018. |
I didn't see anyone making tests for #136 so I've started by making the existing test pass.
I also had to fiddle with the order of HTML attributes in 9 tests in
react-snap/tests/run.test.js
. not sure if i should commit/PR those.