Proxy / CDN Config Implementation w/ tests #179
+54
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementing proxy.
TypeError: Failed to fetch
stereobooster
force-pushed
the
master
branch
2 times, most recently
from
ae782b6
to
193b27b
Compare
|
I'm looking forward it |
|
Thanks for the poke. I think i finished this before, but i guess i have to re-merge due to the force push |
|
@stereobooster any chance this might get added?
React-snap is really great, but this feature is missing. I'm aware it wasn't requested a lot, but the issue related to this is from 2 Jan 2018. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't see anyone making tests for #136 so I've started by making the existing test pass.
I also had to fiddle with the order of HTML attributes in 9 tests in
react-snap/tests/run.test.js. not sure if i should commit/PR those.